Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto closing tags #2479

Closed

Conversation

Akhilbisht798
Copy link
Contributor

@Akhilbisht798 Akhilbisht798 commented Sep 28, 2023

Fixes #2477

Screenshot from 2023-09-29 10-50-02

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@rajatmohan22
Copy link
Contributor

It seems like you've copied and pasted the same snippet repeatedly, and it doesn't appear to have any translations included

@Akhilbisht798
Copy link
Contributor Author

@rajatmohan22, Hey ya for translation i have done that cause i don't known every language. I have discussed this on discord from maintainers and they have told me to just put english translation in every language and raise a new issue to change them.

Although i have changed hindi myself as i am native hindi speaker and in rest of the case i have just put english translation.

After this pr get merged. we will open a issue to change all the translation.

@raclim raclim added Feature Request Area:Editor For CodeMirror-related features labels Jan 26, 2024
@raclim
Copy link
Collaborator

raclim commented Jun 13, 2024

Thanks for your work on this! We're about to upgrade our current CodeMirror version from 5->6, which will also touch on revamping some of its add-ons. Since a majority of this might look different from what's included in this PR, I'm going to close this for now. I'm sorry that we couldn't get this in, but please feel free to reopen this PR with any updates or check out our other issues!

@raclim raclim closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Editor For CodeMirror-related features Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-closing tags in HTML file
3 participants