Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor promises using async/await for apikey #2510

Conversation

adityagarg06
Copy link
Contributor

@adityagarg06 adityagarg06 commented Oct 18, 2023

Partially Fixes: #521
Changes:
Refactor the promises to async/await syntax for the apikey file.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@adityagarg06
Copy link
Contributor Author

Hi @lindapaiste please consider the PR.

@lindapaiste
Copy link
Collaborator

We have a bunch of unit tests to make sure that we are getting the correct response. These tests are failing and showing that all of the errors are returning a 500 code instead of the appropriate code for each situation. We cannot consider this PR until it passes the tests.

@raclim
Copy link
Collaborator

raclim commented Jan 16, 2024

Since this isn't passing tests and some time has passed I'm going to close this PR for now. Please feel free to revisit this in the future or reopen a new one!

@raclim raclim closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promisify all mongoose queries using async/await
3 participants