Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete legacy mobile UI - Fixes #2557 #2559

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

lindapaiste
Copy link
Collaborator

@lindapaiste lindapaiste commented Nov 2, 2023

Fixes #2557
Progress on #2555

This will clear up a lot of developer confusion and ensure that what contributors see on localhost matches what we are using in production.

Changes:

  • Delete MOBILE_ENABLED feature flag from .env as the new responsive design is always enabled.
  • Delete mobileFirst HOC which was previously used to show the experimental mobile design on localhost when the MOBILE_ENABLED flag was set.
  • Delete component-switching via mobileFirst from the app routing.
  • Delete the components MobileIDEView etc. which are no longer used anywhere.
  • Delete elemental UI components (ActionStrip, etc.) which were only used in those views.
  • Moved remained component IconButton to the /common folder and deleted the client/components/mobile folder.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste requested a review from raclim November 2, 2023 19:00
@raclim raclim added this to the MINOR Release milestone Nov 2, 2023
Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely Done.

@raclim
Copy link
Collaborator

raclim commented Nov 3, 2023

Thanks for working on this! Glad to see some of the errors that were starting to pop up from the legacy components resolved!

I'm wondering if you think if the files within the components/mobile folder should be deleted here too?

@lindapaiste
Copy link
Collaborator Author

I'm wondering if you think if the files within the components/mobile folder should be deleted here too?

I’ll take a look. I think IconButton is the only one still in use. We can move that to a different folder.

@raclim
Copy link
Collaborator

raclim commented Nov 7, 2023

Just did a check as well and think you're right! I think deleting that file and moving the IconButton would be great here, but also could merge in this PR as is!

@lindapaiste
Copy link
Collaborator Author

Just did a check as well and think you're right! I think deleting that file and moving the IconButton would be great here, but also could merge in this PR as is!

I just deleted those files. 🪓

Next up...we need to delete the translations for the components that we deleted, but I want to give that a closer look because some of those phrases we may want to move rather than delete ("My Stuff" is one). There's a few places in the new code where phrases are not translated. //TODO

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks so much again for cleaning this up!

@raclim raclim merged commit 4fe6349 into processing:develop Nov 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

localhost displays incorrect mobile design due to legacy mobileFirst components
3 participants