-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete legacy mobile UI - Fixes #2557 #2559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely Done.
Thanks for working on this! Glad to see some of the errors that were starting to pop up from the legacy components resolved! I'm wondering if you think if the files within the components/mobile folder should be deleted here too? |
I’ll take a look. I think IconButton is the only one still in use. We can move that to a different folder. |
Just did a check as well and think you're right! I think deleting that file and moving the IconButton would be great here, but also could merge in this PR as is! |
I just deleted those files. 🪓 Next up...we need to delete the translations for the components that we deleted, but I want to give that a closer look because some of those phrases we may want to move rather than delete ("My Stuff" is one). There's a few places in the new code where phrases are not translated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks so much again for cleaning this up!
Fixes #2557
Progress on #2555
This will clear up a lot of developer confusion and ensure that what contributors see on
localhost
matches what we are using in production.Changes:
MOBILE_ENABLED
feature flag from.env
as the new responsive design is always enabled.mobileFirst
HOC which was previously used to show the experimental mobile design onlocalhost
when theMOBILE_ENABLED
flag was set.mobileFirst
from the app routing.MobileIDEView
etc. which are no longer used anywhere.ActionStrip
, etc.) which were only used in those views.IconButton
to the/common
folder and deleted theclient/components/mobile
folder.I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123