-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-#2923 added test for the Account Form. #2955
Conversation
I have added the test for Account from please review it. if these test feel good to you then i started to write for the other component as well. In the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are very good tests! 👍
I'm often not a fan of mocking because it's testing a fake behavior and not the real behavior. But this is a case where it makes sense because I don't think that our dev/test setup has actual user accounts associated with it. Maybe it does? We should look into that. When it comes to testing the login screen it would be cool if we could try submitting a wrong password and verify that it fails vs a correct password and verify that it succeeds.
@lindapaiste |
@lindapaiste |
61577b9
to
1ca6b67
Compare
1ca6b67
to
b994495
Compare
b994495
to
afb41f3
Compare
thanks, these are great tests! : ) lgtm to me overall but you will probably have to move the test locations as it looks like the files have moved locations a little bit |
Ref #2923
Changes:
Added the test for AccountForm.
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123