Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Dropdown/DropdownMenu.jsx with keyboard accessibility. #3313

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Rajnish2105
Copy link

Refactor -

  1. Updated DropdownMenu.jsx to allow keyboard access to the drop down.
  2. Made the component Generic instead of Wrapper.
  3. TabledropDown now accepts props like items (name, onclick, href, target, hideif) and aria-label.
  4. Update several component which used TabledropDown (styled DropdownMen) to send props to the component

Changes:
https://github.com/user-attachments/assets/d2be653a-6cbb-447b-87dd-dea62cc1c3c6

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant