Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation of amplitude.disconnect() method in p5.js-sound library #5866

Closed
wants to merge 1 commit into from
Closed

Conversation

Nitesh639
Copy link

Resolves: Documentation of amplitude.disconnect() method with example in p5.js-sound library

Changes: lib/addons/p5.sound.js

Screenshots of the change:
Screenshot from 2022-11-22 12-17-06
Screenshot from 2022-11-22 12-17-17

PR Checklist

@welcome
Copy link

welcome bot commented Nov 22, 2022

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@davepagurek
Copy link
Contributor

davepagurek commented Nov 23, 2022

I think we want to make your change first in your other PR processing/p5.js-sound#682 since the p5.sound library in this repository is, I think, just a compiled version of that library. (@Qianqianye, is my understanding of that correct? Is there a process for updating it?)

I'm going to re-open your PR there first, and then once that's done and merged, I'll figure out what needs to be done to mirror that here!

@Nitesh639
Copy link
Author

@davepagurek ok, I will do it. If it's required.

@limzykenneth
Copy link
Member

Yes, changes to the p5.Sound library should be made in the p5.Sound repo and it will be copied over when p5.Sound wants to create a new release. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants