-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solves issue #6787 #6809
Merged
Merged
Solves issue #6787 #6809
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d7f615c
Added calculateBoundingBox()
Garima3110 fe862c7
Merge remote-tracking branch 'upstream/main'
Garima3110 31fdc5f
Added unit test for calculateBoundingBox()
Garima3110 dc9c88b
Merge remote-tracking branch 'upstream/main' into boundingBox
Garima3110 399bc0c
Updated inline docs+ minor fixes
Garima3110 f4edd6e
Merge remote-tracking branch 'upstream/main' into boundingBox
Garima3110 e47c1ce
Minor fixes
Garima3110 f99444a
Fixing the unit test
Garima3110 4c0734b
Added example
Garima3110 ed5739f
Minor formatting
Garima3110 6a7244b
Minor changes in formatting
Garima3110 71f56e5
Merge remote-tracking branch 'upstream/main' into boundingBox
Garima3110 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see tests are still failing,
min
andmax
are also p5 globals and won't be defined in instance mode. I thinkMath.min
andMath.max
will fix it though