Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed repeated key presses when a modifier key is held #7435

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

Rishab87
Copy link
Contributor

Resolves #7282

Changes:
As @davepagurek proposed above, I have used .repeat check to make sure we can capture repeated presses and recording which keys were pressed in combination with the meta key, and then when the meta key is released, manually update _downkeys so that they're all set to false

Screenshots of the change:

img

PR Checklist

Copy link

welcome bot commented Dec 19, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

src/events/keyboard.js Outdated Show resolved Hide resolved
Copy link
Contributor

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes look good to merge, thank you @Rishab87!

Next time, we ask that you wait to be assigned to an issue before filing a PR, as for this one someone else had been assigned. Our contributor docs mention:

You should not "jump the queue" by filing a PR for an issue that either someone else has indicated willingness to submit a contribution or has already been assigned to someone else.

@davepagurek davepagurek merged commit 4443f7c into processing:main Dec 20, 2024
2 checks passed
@Rishab87
Copy link
Contributor Author

time, we ask that you wait to be assigned to an issue before filing a PR, as for this one someone else had been assigned.

@davepagurek sure thing! I'll keep that in mind from next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated key presses when a modifier key is held do not fire events
2 participants