[ESP32] Removed Redundant VerifyOrReturn Statement from GetLogForIntent() in DiagnosticLogsProviderDelegate #36952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36952: Size comparison from 1b4c56c to b3d7d7c Full report (19 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
pimpalemahesh
force-pushed
the
fix/delegate
branch
from
b3d7d7c to
2a0c268
Compare
|
PR #36952: Size comparison from 1b4c56c to 2a0c268 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Looks good, but a question about EndLogCollection. When called with a non-successful second argument, it returns failure in this file, right? Is that allowed? Expected? The API documentation for the new EndLogCollection overload does not say what the return value means when EndLogCollection is called with an error....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The VerifyOrReturn statement after the CollectLog() method caused an early return in case of an error, preventing EndLogCollection() from being called. This behavior is incorrect, as EndLogCollection() must be called in both success and failure scenarios.
Change Overview
Removed the VerifyOrReturn statement following the CollectLog() method.
Modified the code to ensure that EndLogCollection() is called regardless of the success or failure of CollectLog().