Skip to content

Commit

Permalink
Update shaded dependencies in BOM
Browse files Browse the repository at this point in the history
Signed-off-by: Fabian Stäber <[email protected]>
  • Loading branch information
fstab committed Mar 22, 2024
1 parent 71cf428 commit c9c5143
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
10 changes: 7 additions & 3 deletions MAINTAINER_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,11 @@ Step 3: Update `prometheus-metrics-exporter-opentelemetry`
* Change the version of the `prometheus-metrics-shaded-opentelemetry` dependency in `pom.xml` to `${project.version}`.
* Use find-and-replace to update the version numbers in the imported package names in the source code of `prometheus-metrics-exporter-opentelemetry`.

Step 4: Release
Step 4: Update `prometheus-metrics-bom`

* Set the shaded dependency version property to `${project.version}` in `prometheus-metrics-bom/pom.xml`

Step 5: Release

_see below_

Expand All @@ -45,7 +49,7 @@ _see below_
Create a commit to temporarily add shaded dependencies to the project:

* Add the `prometheus-metrics-shaded-dependencies` module to the root `pom.xml`.
* Change the versions of the shaded dependencies to `${project.version}` in `prometheus-metrics-exporter-opentelemetry` and `prometheus-metrics-exposition-formats`.
* Change the versions of the shaded dependencies to `${project.version}` in `prometheus-metrics-exporter-opentelemetry`, `prometheus-metrics-exposition-formats`, and `prometheus-metrics-bom`.

Release:

Expand All @@ -61,4 +65,4 @@ After that, manually verify the uploaded artifacts on [https://oss.sonatype.org/
Create a commit to remove dependencies from the build (undoing the first step):

* Comment out the `prometheus-metrics-shaded-dependencies` module to the root `pom.xml`.
* Change the versions of the shaded dependencies to the latest released version on Maven Central in `prometheus-metrics-exporter-opentelemetry` and `prometheus-metrics-exposition-formats`.
* Change the versions of the shaded dependencies to the latest released version on Maven Central in `prometheus-metrics-exporter-opentelemetry`, `prometheus-metrics-exposition-formats`, and `prometheus-metrics-bom`.
2 changes: 1 addition & 1 deletion prometheus-metrics-bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</description>

<properties>
<prometheus.metrics.shaded.dependencies.version>1.1.0</prometheus.metrics.shaded.dependencies.version>
<prometheus.metrics.shaded.dependencies.version>${project.version}</prometheus.metrics.shaded.dependencies.version>
</properties>

<licenses>
Expand Down

0 comments on commit c9c5143

Please sign in to comment.