-
Notifications
You must be signed in to change notification settings - Fork 805
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add optional SpanContext parameter to ExemplarSampler (#929)
Signed-off-by: Fabian Stäber <[email protected]>
- Loading branch information
Showing
5 changed files
with
124 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
103 changes: 103 additions & 0 deletions
103
...rics-core/src/test/java/io/prometheus/metrics/core/exemplars/SpanContextSupplierTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| package io.prometheus.metrics.core.exemplars; | ||
|
|
||
| import io.prometheus.metrics.config.ExemplarsProperties; | ||
| import io.prometheus.metrics.model.snapshots.Exemplar; | ||
| import io.prometheus.metrics.model.snapshots.Exemplars; | ||
| import io.prometheus.metrics.tracer.common.SpanContext; | ||
| import io.prometheus.metrics.tracer.initializer.SpanContextSupplier; | ||
| import org.junit.*; | ||
|
|
||
| import static io.prometheus.metrics.model.snapshots.Exemplar.TRACE_ID; | ||
|
|
||
| public class SpanContextSupplierTest { | ||
|
|
||
| public SpanContext makeSpanContext(String traceId, String spanId) { | ||
|
|
||
| return new SpanContext() { | ||
| @Override | ||
| public String getCurrentTraceId() { | ||
| return traceId; | ||
| } | ||
|
|
||
| @Override | ||
| public String getCurrentSpanId() { | ||
| return spanId; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isCurrentSpanSampled() { | ||
| return true; | ||
| } | ||
|
|
||
| @Override | ||
| public void markCurrentSpanAsExemplar() { | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| SpanContext spanContextA = makeSpanContext("A", "a"); | ||
| SpanContext spanContextB = makeSpanContext("B", "b"); | ||
| SpanContext origSpanContext; | ||
|
|
||
| ExemplarSamplerConfig config = new ExemplarSamplerConfig( | ||
| 10, // min retention period in milliseconds | ||
| 20, // max retention period in milliseconds | ||
| 5, // sample interval in millisecnods | ||
| 1, // number of exemplars | ||
| null // histogram upper bounds | ||
| ); | ||
|
|
||
| @Before | ||
| public void setUp() { | ||
| origSpanContext = SpanContextSupplier.getSpanContext(); | ||
| } | ||
|
|
||
| @After | ||
| public void tearDown() { | ||
| SpanContextSupplier.setSpanContext(origSpanContext); | ||
| } | ||
|
|
||
| /** | ||
| * Test: When a {@link SpanContext} is provided as a constructor argument to the {@link ExemplarSampler}, | ||
| * then that {@link SpanContext} is used, not the one from the {@link SpanContextSupplier}. | ||
| */ | ||
| @Test | ||
| public void testConstructorInjection() { | ||
| ExemplarsProperties properties = ExemplarsProperties.builder().build(); | ||
| ExemplarSamplerConfig config = new ExemplarSamplerConfig(properties, 1); | ||
| ExemplarSampler exemplarSampler = new ExemplarSampler(config, spanContextA); | ||
|
|
||
| SpanContextSupplier.setSpanContext(spanContextB); | ||
| exemplarSampler.observe(1.0); | ||
| Exemplars exemplars = exemplarSampler.collect(); | ||
| Assert.assertEquals(1, exemplars.size()); | ||
| Exemplar exemplar = exemplars.get(0); | ||
| Assert.assertEquals("A", exemplar.getLabels().get(TRACE_ID)); | ||
| } | ||
|
|
||
| /** | ||
| * When the global {@link SpanContext} is updated via {@link SpanContextSupplier#setSpanContext(SpanContext)}, | ||
| * the {@link ExemplarSampler} recognizes the update (unless a {@link ExemplarSampler} was provided as | ||
| * constructor argument to {@link ExemplarSampler}). | ||
| */ | ||
| @Test | ||
| public void testUpdateSpanContext() throws InterruptedException { | ||
| ExemplarSampler exemplarSampler = new ExemplarSampler(config); | ||
|
|
||
| SpanContextSupplier.setSpanContext(spanContextB); | ||
| exemplarSampler.observe(1.0); | ||
| Exemplars exemplars = exemplarSampler.collect(); | ||
| Assert.assertEquals(1, exemplars.size()); | ||
| Exemplar exemplar = exemplars.get(0); | ||
| Assert.assertEquals("B", exemplar.getLabels().get(TRACE_ID)); | ||
|
|
||
| Thread.sleep(15); // more than the minimum retention period defined in config above. | ||
|
|
||
| SpanContextSupplier.setSpanContext(spanContextA); | ||
| exemplarSampler.observe(1.0); | ||
| exemplars = exemplarSampler.collect(); | ||
| Assert.assertEquals(1, exemplars.size()); | ||
| exemplar = exemplars.get(0); | ||
| Assert.assertEquals("A", exemplar.getLabels().get(TRACE_ID)); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters