Add support for dw-metrics 4.x

[kingster]

Adding support for com.codahale.metrics.MetricRegistry(Dropwizard Metrics 4.x)

Completes #867

[kingster]

Hi @fstab Please do review this PR, this solves for Dropwizard 4.x metrics support.

[zeitlinger]

Thanks for the contribution 😄

[zeitlinger]

test dependencies are added in the parent already:

client_java/pom.xml

Lines 103 to 143 in 9a0848d

	<dependency>
	<groupId>org.junit.jupiter</groupId>
	<artifactId>junit-jupiter-engine</artifactId>
	<version>${junit-jupiter.version}</version>
	<scope>test</scope>
	</dependency>
	<dependency>
	<groupId>org.junit.jupiter</groupId>
	<artifactId>junit-jupiter-params</artifactId>
	<version>${junit-jupiter.version}</version>
	<scope>test</scope>
	</dependency>
	<dependency>
	<groupId>org.mockito</groupId>
	<artifactId>mockito-core</artifactId>
	<version>5.14.2</version>
	<scope>test</scope>
	</dependency>
	<dependency>
	<groupId>org.assertj</groupId>
	<artifactId>assertj-core</artifactId>
	<version>3.26.3</version>
	<scope>test</scope>
	</dependency>
	<dependency>
	<groupId>com.google.guava</groupId>
	<artifactId>guava</artifactId>
	<scope>test</scope>
	</dependency>
	<dependency>
	<groupId>org.slf4j</groupId>
	<artifactId>slf4j-simple</artifactId>
	<version>2.0.16</version>
	<scope>test</scope>
	</dependency>
	<dependency>
	<groupId>org.junit-pioneer</groupId>
	<artifactId>junit-pioneer</artifactId>
	<version>2.3.0</version>
	<scope>test</scope>
	</dependency>

[kingster]

Sure, removed these.

[zeitlinger]

should only depend on prometheus-metrics-exposition-textformats

[kingster]

Sure, changed this.

[zeitlinger]

please use assertj for all assertions

[kingster]

Thanks for pointing this out. Fixed this

[zeitlinger]

did the assertion not work?

[kingster]

It works, just that its not a string comparison, hence this comment is to explain why its not asserted like in other cases.

[zeitlinger]

can you test it like here:

client_java/prometheus-metrics-core/src/test/java/io/prometheus/metrics/core/metrics/HistogramTest.java

Line 950 in e486e4d

assertThat(out).hasToString(expectedTextFormat);

?

[kingster]

I think doing it that way will lead to a flaky test-suite, because the problem is in the dw metrics4 histogram. This is something that had happened earlier and that is specially why this approach was taken.

fca49ff

I took reference of this method from the dw5 implementation.

[kingster]

Updated the pr to use

assertThat(textFormat)
        .satisfiesAnyOf(
            text -> assertThat(text).isEqualTo(expected1),
            text -> assertThat(text).isEqualTo(expected2));

So that it matches the exact output, and is a much simpler test.

[kingster]

@zeitlinger Have made the changes as requested, could you please have a look again?

[kingster]

Thank you @zeitlinger

Are snapshot versions published at any repository? If not when is the next planned version release?

[zeitlinger]

Thank you @zeitlinger

Are snapshot versions published at any repository? If not when is the next planned version release?

1.3.5 has just been released 😄