Skip to content

Commit

Permalink
Merge pull request #292 from prometheus/sinjo-prepare-4-2-1
Browse files Browse the repository at this point in the history
Prepare release 4.2.1
  • Loading branch information
Sinjo authored Aug 4, 2023
2 parents 8dc02e4 + a9e8a30 commit e144d62
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
17 changes: 17 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,23 @@

_None outstanding_

# 4.2.1 / 2023-08-04

_**Codename:** If a bug falls in the forest_

## Bug fixes

- [#291](https://github.com/prometheus/client_ruby/pull/291) Handle `/` in job name in
`Prometheus::Client::Push`:
Previously, if you included a `/` in your job name when using the Pushgateway client,
you'd get a `400` error back as we didn't encode it properly. We now base64 encode it
per the Pushgateway spec.

It's possible that nobody has hit this bug (`/` is fairly unlikely to appear in a job
name) or that the error message (a `400` from Pushgateway with a complaint about an
odd number of path components) didn't make it look like a bug in the Ruby client.
Either way, this hopefully brings us fully in line with the spec!

# 4.2.0 / 2023-07-25

_**Codename:** Funny number_
Expand Down
2 changes: 1 addition & 1 deletion lib/prometheus/client/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

module Prometheus
module Client
VERSION = '4.2.0'
VERSION = '4.2.1'
end
end

0 comments on commit e144d62

Please sign in to comment.