Add Schneider_PM55XX MIB to downloads for SNMP generator #1142
Conversation
fbegyn
force-pushed
the
add-schneider-pm5xx-mib
branch
2 times, most recently
from
d764c20 to
62be456
Compare
generator/Makefile
Outdated
| @curl $(CURL_OPTS) -o $(TMP) $(SCHNEIDER_PM55XX_URL) | ||
| @unzip -j -d $(MIBDIR) $(TMP) PM5560_PM5563_v2.1.0/SchneiderPM55xx_V01_13.mib | ||
| # Workaround invalid character in Schneider MIB | ||
| @sed -i 's/_//g' $(MIBDIR)/SchneiderPM55xx_V01_13.mib |
There was a problem hiding this comment.
Is this still necessary, given that we support mibopts (#873) and you can simply allow those characters by adding mibopt "u" ?
There was a problem hiding this comment.
Ah, totally slipped my mind that is an option. Switched it out in favor of your idea. The --snmp.mibopts u works perfectly.
There was a problem hiding this comment.
Hmm, I'm not sure I'm happy with adding a MIB that requires custom mibopts. Perhaps we should adjust the generator default mibopts?
Or maybe get Schneider to fix their MIB. Cisco had some similar issues in the AIRESPACE-WIRELESS-MIB that I got them to fix. Teach them about smilint 😁
fbegyn
force-pushed
the
add-schneider-pm5xx-mib
branch
from
62be456 to
5c043ab
Compare
fbegyn
force-pushed
the
add-schneider-pm5xx-mib
branch
from
0d047d7 to
43c5b1b
Compare
|
Rebased the code and tested with a few iterations locally. Still needs the |
|
The underscores issue seems to be somewhat common. I think we should add it to the flag default in What do you think @bastischubert? |
|
I also think we should have it in the generator as it takes too much effort for contributors do deal with unclean mibs. |
Signed-off-by: Francis Begyn <[email protected]>
I missed the `--snmp.mibopts` before. By using `--snmp.mibopts u`, this error can be prevented and it offers a much more robust way to handle the problem than using `sed` in a makefile. Signed-off-by: Francis Begyn <[email protected]>
Signed-off-by: Francis Begyn <[email protected]>
Signed-off-by: Francis Begyn <[email protected]>
fbegyn
force-pushed
the
add-schneider-pm5xx-mib
branch
from
43c5b1b to
130f5f6
Compare
Signed-off-by: Francis Begyn <[email protected]>
fbegyn
force-pushed
the
add-schneider-pm5xx-mib
branch
from
45f3ed5 to
2566023
Compare
Simple addition of the Schneider MIB for the PM55XX device series.