Preparation neoforge #282
Open
Preparation neoforge #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordRalex
reviewed
Jun 1, 2024
LordRalex
reviewed
Jun 1, 2024
Also change default minecraft back to java 17 for now
LordRalex
reviewed
Jun 1, 2024
| "ip": "0.0.0.0", | ||
| "port": "25565", | ||
| "eula": true, | ||
| "version": "1.20.1", |
There was a problem hiding this comment.
Might be better to just use 1.20.4 or something. Neo even suggests Forge for 1.20.1 instead. And, the actual changes are in the .2 onward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a couple of things:
In regards to 2: I wasn't sure if it was preferred to combined neoforge and forge curseforge templates or separate them, by previous examples it looks like it's preferred to separate them so I did so