Skip to content

Commit

Permalink
Merge pull request #184 from pulp-platform/aottaviano/fix
Browse files Browse the repository at this point in the history
hw: Fix localparam array direction
  • Loading branch information
alex96295 authored Oct 6, 2023
2 parents 5189614 + 03d3ae3 commit a7dac17
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions hw/carfield.sv
Original file line number Diff line number Diff line change
Expand Up @@ -583,12 +583,12 @@ logic [NumDomains-1:0] rsts_n;
// every target domain to use different clock frequencies.
// 3. The internal clock gate of the clock divider is used to provide clock gating for the domain.

localparam int unsigned DomainClkDivValue[NumDomains] = '{PeriphDomainClkDivValue ,
SafedDomainClkDivValue ,
SecdDomainClkDivValue ,
IntClusterDomainClkDivValue ,
FPClusterDomainClkDivValue ,
L2DomainClkDivValue };
localparam int unsigned DomainClkDivValue[NumDomains-1:0] = '{PeriphDomainClkDivValue ,

Check warning on line 586 in hw/carfield.sv

View workflow job for this annotation

GitHub Actions / verible-verilog-lint

[verible-verilog-lint] hw/carfield.sv#L586

Unpacked dimension range must be declared in big-endian ([0:N-1]) order. Declare zero-based big-endian unpacked dimensions sized as [N]. [Style: unpacked-ordering] [unpacked-dimensions-range-ordering]
Raw output
message:"Unpacked dimension range must be declared in big-endian ([0:N-1]) order.  Declare zero-based big-endian unpacked dimensions sized as [N]. [Style: unpacked-ordering] [unpacked-dimensions-range-ordering]"  location:{path:"hw/carfield.sv"  range:{start:{line:586  column:43}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}
SafedDomainClkDivValue ,
SecdDomainClkDivValue ,
IntClusterDomainClkDivValue ,
FPClusterDomainClkDivValue ,
L2DomainClkDivValue };

for (genvar i = 0; i < NumDomains; i++) begin : gen_domain_clock_mux
clk_mux_glitch_free #(
Expand Down

0 comments on commit a7dac17

Please sign in to comment.