Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integer cluster offloading #183

Merged
merged 3 commits into from
Oct 7, 2023
Merged

Fix integer cluster offloading #183

merged 3 commits into from
Oct 7, 2023

Conversation

yvantor
Copy link
Contributor

@yvantor yvantor commented Oct 6, 2023

No description provided.

@yvantor yvantor requested a review from alex96295 as a code owner October 6, 2023 07:37
@yvantor yvantor changed the title Reparing integer cluster offloading test. Repare integer cluster offloading Oct 6, 2023
@alex96295 alex96295 changed the title Repare integer cluster offloading Fix integer cluster offloading Oct 6, 2023
@alex96295
Copy link
Collaborator

Can we initially merge this one to include the HW modifications in main already, or do you want to wait? I would merge it already (provided the test fix doesn't require HW changes)

@yvantor
Copy link
Contributor Author

yvantor commented Oct 6, 2023

Can we initially merge this one to include the HW modifications in main already, or do you want to wait? I would merge it already (provided the test fix doesn't require HW changes)

Can we wait for a couple of hours more? I also need to push other changes in HW (not related to the broken CI)

@alex96295
Copy link
Collaborator

Can we initially merge this one to include the HW modifications in main already, or do you want to wait? I would merge it already (provided the test fix doesn't require HW changes)

Can we wait for a couple of hours more? I also need to push other changes in HW (not related to the broken CI)

sure man, just to know ;)

@yvantor
Copy link
Contributor Author

yvantor commented Oct 6, 2023

@alex96295 if you want to review this, when the CI concludes we can merge :)

@yvantor yvantor self-assigned this Oct 6, 2023
@alex96295 alex96295 added bug Something isn't working bug-fix Something wasn't working and it is being fixed labels Oct 6, 2023
alex96295
alex96295 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@alex96295 alex96295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alex96295 alex96295 merged commit 233989a into main Oct 7, 2023
7 checks passed
@alex96295 alex96295 deleted the intcl-fix branch October 7, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex96295 alex96295 alex96295 approved these changes

Assignees

@yvantor yvantor

Labels
bug Something isn't working bug-fix Something wasn't working and it is being fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yvantor @alex96295