-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup simulation-based testing flow #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! In principle looks good, but I have a few comments. Most important, I would like to support other simulation platforms such as GVSoC in the future.
Furthermore, if you have some time and extend the Sphinx documentation with a minimal explanation of how to run the test, this would be great, but is not strictly necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. I was thinking on another level of abstraction, and most comments are resolved now. Open points:
- Rename "Simulation Binary"
- List of available models
Fixed the open points, and actually flip-flopped on test building; I think it's not a bad idea to make sure the tests build in any case (Ensures the toolchain works, the code is not deeply broken,...), so I reenabled the default building of tests, but added a switch for adding them to the ctest pipeline, which is now contingent on TEST_MODE being "simulation" - this can be easily extended for gvsoc or other platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, except the formatting of the RST documentation for the CMake add_chimera_subdirectories
function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR fills in the gaps for running chimera-sdk tests with simulation tools (VCS, Verilator).
Added
Changed
SIMULATION_BINARY
with plusargs forBINARY
andPRELMODE
corresponding to the chimera / cheshire testbench convention.