Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(possible?) clarification on spectrl2 example #2207

Closed
RDaxini opened this issue Sep 11, 2024 · 0 comments · Fixed by #2208
Closed

(possible?) clarification on spectrl2 example #2207

RDaxini opened this issue Sep 11, 2024 · 0 comments · Fixed by #2208
Milestone

Comments

@RDaxini
Copy link
Contributor

RDaxini commented Sep 11, 2024

Is your feature request related to a problem? Please describe.
While working on #2206 I noticed something in the SPECTRL2 example that might benefit from clarification (in particular if considering a new user)

I also noticed the doi role in the references is incorrect

Describe the solution you'd like
Clarification/revision
Correct doi role

Additional context
Sentence in question

Note that because we are calculating
the spectra for more than one set of conditions, we will get back 2-D
arrays (one dimension for wavelength, one for time).

While it is true the output does contain 2-D arrays, the full output is a dictionary of both 2-D and 1-D arrays. I think it would help if this was this was clarified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants