Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous updates to spectrl2 gallery example #2208

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Miscellaneous updates to spectrl2 gallery example #2208

merged 5 commits into from
Sep 11, 2024

Conversation

RDaxini
Copy link
Contributor

@RDaxini RDaxini commented Sep 11, 2024 •
edited by cwhanse
Loading

  • Closes (possible?) clarification on spectrl2 example #2207
  • I am familiar with the contributing guidelines
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Changes summary:
corrected doi in reference, suggested alternative wording for one section regarding the function

@RDaxini RDaxini marked this pull request as ready for review September 11, 2024 15:03
@echedey-ls
Copy link
Contributor

For reviewers:

@kandersolar kandersolar added this to the v0.11.1 milestone Sep 11, 2024
@kandersolar kandersolar merged commit def8c87 into pvlib:main Sep 11, 2024
31 checks passed
@RDaxini RDaxini deleted the misc_updates_spectrl2_example branch September 11, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echedey-ls echedey-ls echedey-ls approved these changes

@kandersolar kandersolar kandersolar approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
v0.11.1
Development

Successfully merging this pull request may close these issues.

(possible?) clarification on spectrl2 example
4 participants
@RDaxini @echedey-ls @kandersolar @cwhanse