Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python and dependency bounds illustration #2339

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

markcampanelli
Copy link
Contributor

@markcampanelli markcampanelli commented Dec 22, 2024

At this point this PR is for illustration only. Things to add/update would be:

  • Adding Python 3.13 to the test matrix.
  • A dependency management policy in the documentation. (See Python 3.13 preparation #2201 (comment))
  • Look into any changes/simplifications in CI that might be possible by calling out the Python upper limits in the optional dependencies.
  • timetimezones.rst would be revised to use the standard library's timezone package instead of pytz, which is still used by pandas. Moved to Replace pytz with standard library's zoneinfo #2343
  • Closes #xxxx (Inspired by Python 3.13 preparation #2201)
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@markcampanelli markcampanelli changed the title Bound python, non-optional deps, and some optional deps above [DRAFT] Bound python, non-optional deps, and some optional deps above Dec 22, 2024
@markcampanelli markcampanelli changed the title [DRAFT] Bound python, non-optional deps, and some optional deps above [DRAFT] Python and dependency bounds and replace pytz with zoneinfo Dec 23, 2024
@echedey-ls
Copy link
Contributor

Could you put the changes relative to zoneinfo into another PR?
I have the gut feeling one of the proposals will be more controversial than the other, and it's easier to follow a conversation on a proposal than on many at the same time.

@markcampanelli
Copy link
Contributor Author

Could you put the changes relative to zoneinfo into another PR? I have the gut feeling one of the proposals will be more controversial than the other, and it's easier to follow a conversation on a proposal than on many at the same time.

@echedey-ls Thanks for your patience and feedback as I learn how to best present my ideas to others in digestible chunks. I will split these two ideas up even though they originally came to me together :).

Question: Should I label/communicate my “demonstration/experimental” PRs with something other than [DRAFT]?

@echedey-ls
Copy link
Contributor

Question: Should I label/communicate my “demonstration/experimental” PRs with something other than [DRAFT]?

You can set them as drafts, there is a button on top right of the PR page, in the reviewers box, that says "Convert to draft". When you first open them, in the Open PR button there is dropdown to select Open as draft. Said that, it's not that important. Here in pvlib there is no convention, neither for the titles. I like to use the brackets so I can browse my PRs easier. Feel free to find what works best for you and be comfortable with your development procedures.

@echedey-ls Thanks for your patience

Thanks to you for proactively raising awareness of the user's needs.

@markcampanelli markcampanelli marked this pull request as draft December 23, 2024 16:52
@markcampanelli markcampanelli changed the title [DRAFT] Python and dependency bounds and replace pytz with zoneinfo [DRAFT] Python and dependency bounds Dec 23, 2024
@markcampanelli markcampanelli changed the title [DRAFT] Python and dependency bounds Python and dependency bounds illustration Dec 23, 2024
@markcampanelli
Copy link
Contributor Author

@echedey-ls Please forgive the bigger diff than perhaps necessary in the pyproject.toml. I'm a stickler for alphabetizing dependencies, imports, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants