-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python and dependency bounds illustration #2339
base: main
Are you sure you want to change the base?
Conversation
Could you put the changes relative to zoneinfo into another PR? |
@echedey-ls Thanks for your patience and feedback as I learn how to best present my ideas to others in digestible chunks. I will split these two ideas up even though they originally came to me together :). Question: Should I label/communicate my “demonstration/experimental” PRs with something other than [DRAFT]? |
You can set them as drafts, there is a button on top right of the PR page, in the reviewers box, that says "Convert to draft". When you first open them, in the Open PR button there is dropdown to select Open as draft. Said that, it's not that important. Here in pvlib there is no convention, neither for the titles. I like to use the brackets so I can browse my PRs easier. Feel free to find what works best for you and be comfortable with your development procedures.
Thanks to you for proactively raising awareness of the user's needs. |
@echedey-ls Please forgive the bigger diff than perhaps necessary in the |
At this point this PR is for illustration only. Things to add/update would be:
optional
dependencies.timetimezones.rst would be revised to use the standard library'sMoved to Replace pytz with standard library's zoneinfo #2343timezone
package instead ofpytz
, which is still used bypandas
.docs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.