-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codespell pre-commit-hook #9781
base: main
Are you sure you want to change the base?
Conversation
Looks good! |
Does anyone have an idea why pre-commit fails in CI? It seems to ignore the skip of whats-new |
"PIE", # flake8-pie | ||
"TID", # flake8-tidy-imports (absolute imports) | ||
"PGH", # pygrep-hooks | ||
"F", # Pyflakes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't black usually do 2 whitespaces for comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good question.
I shouldn't have even formatted this even, but pre-commit did that ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which hook was that? As far as I can tell, we don't have anything that would format TOML (yet, we can totally change that).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, might have been format on save in vscode.
I will have to check that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have anything that would format TOML (yet, we can totally change that).
Stumbled across this and thought I'd make #9840 :)
Given the large codebase there were surprisingly few misspellings.
But even better to add a pre-commit hook for that :)