Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell pre-commit-hook #9781

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

headtr1ck
Copy link
Collaborator

Given the large codebase there were surprisingly few misspellings.
But even better to add a pre-commit hook for that :)

@headtr1ck headtr1ck added the Automation Github bots, testing workflows, release automation label Nov 14, 2024
@max-sixty
Copy link
Collaborator

Looks good!

@headtr1ck
Copy link
Collaborator Author

headtr1ck commented Nov 15, 2024

Does anyone have an idea why pre-commit fails in CI?
Locally (Windows) it works for me ..

It seems to ignore the skip of whats-new

@headtr1ck headtr1ck added the plan to merge Final call for comments label Nov 15, 2024
"PIE", # flake8-pie
"TID", # flake8-tidy-imports (absolute imports)
"PGH", # pygrep-hooks
"F", # Pyflakes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't black usually do 2 whitespaces for comments?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good question.
I shouldn't have even formatted this even, but pre-commit did that ;)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which hook was that? As far as I can tell, we don't have anything that would format TOML (yet, we can totally change that).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, might have been format on save in vscode.
I will have to check that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have anything that would format TOML (yet, we can totally change that).

Stumbled across this and thought I'd make #9840 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation Github bots, testing workflows, release automation plan to merge Final call for comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants