Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Invalid escape sequences in docstrings #36

Merged
merged 5 commits into from
Nov 25, 2024
Merged

[FIX] Invalid escape sequences in docstrings #36

merged 5 commits into from
Nov 25, 2024

Conversation

fsoubelet
Copy link
Member

There were two places in optics_functions that would emit the SyntaxWarning: invalid escape sequence ...

This PR fixes it, so we can stop polluting CIs & co.
I am also including some very minor fixes for warnings emerging in the tests (but from test code).

Updated the version with a patch so we can release in the wild.

@fsoubelet fsoubelet added Type: Maintenance Improvements in the code, that are not necessarily visible in functionality. Estimate: Easy Good first issue for newcomers. Straightforward fixes. Status: Review Needed Work currently stopped, untils someone else reviews it. Priority: Low Work on this if you have some spare time. Type: Release Issue preparing for a release. labels Nov 25, 2024
@fsoubelet fsoubelet requested review from JoschD and jgray-19 November 25, 2024 09:36
@fsoubelet fsoubelet self-assigned this Nov 25, 2024
@fsoubelet
Copy link
Member Author

We are getting CI issues with HDF5 install failing on macOS runners. Test suite runs fine on my machine, and on the coverage CI (ubuntu).

@fsoubelet
Copy link
Member Author

Related to the CI issue: Homebrew/homebrew-core#198881

Fix (to be deployed) from GA runners: actions/runner-images#11015

@fsoubelet fsoubelet merged commit 4dd8b48 into master Nov 25, 2024
5 of 21 checks passed
@fsoubelet fsoubelet deleted the invalid_escape_sequence branch November 25, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoschD JoschD JoschD approved these changes

@jgray-19 jgray-19 Awaiting requested review from jgray-19

Assignees

@fsoubelet fsoubelet

Labels
Estimate: Easy Good first issue for newcomers. Straightforward fixes. Priority: Low Work on this if you have some spare time. Status: Review Needed Work currently stopped, untils someone else reviews it. Type: Maintenance Improvements in the code, that are not necessarily visible in functionality. Type: Release Issue preparing for a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsoubelet @JoschD