Suggest var_names when using deprecated API for partial traces
#7289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
An alternative is |
ricardoV94
reviewed
Apr 28, 2024
|
Thanks @lancechua, this seems fine |
ricardoV94
changed the title
var_names when using deprecated API for partial traces
Co-authored-by: Ricardo Vieira <[email protected]>
ricardoV94
approved these changes
Apr 28, 2024
|
|
mkusnetsov
added a commit
to mkusnetsov/pymc
that referenced
this pull request
May 8, 2024
…ces (pymc-devs#7289)" This reverts commit 881030a.
mkusnetsov
pushed a commit
to mkusnetsov/pymc
that referenced
this pull request
Oct 26, 2024
…c-devs#7289) * Update docs when list is passed to trace in sample for partial trace * Change DeprecationWarning to ValueError Co-authored-by: Ricardo Vieira <[email protected]> * Update test_partial_trace_unsupported --------- Co-authored-by: Ricardo Vieira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sampling a partial trace was first done in #271, with the
tracekwarg.Then, it subsequently removed in #6269 raising
DeprecationWarningerror.Partial trace was added back with the
var_nameskwarg in #7206.This PR updates the error message to reference the new
var_nameskwarg instead, astracemay still be suggested by coding LLMs.Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7289.org.readthedocs.build/en/7289/