Stop excluding unisolated packages from build dependencies #21
Conversation
…build into no-host-site
for more information, see https://pre-commit.ci
ryanking13
changed the title
|
Sounds good to me. Relying on |
| return libdir, [ | ||
| str(f.relative_to(libdir)) for f in package_dir.rglob("*") if f.is_file() | ||
| ] |
There was a problem hiding this comment.
So this is trying to get cross-build-files? How does it work in tree? Shouldn't we look at cross-build-files in meta.yaml in that case?
There was a problem hiding this comment.
Also, site-packages-extras maybe should have been called site-packages-cross-files or something a bit more descriptive...
There was a problem hiding this comment.
So this is trying to get cross-build-files? How does it work in tree? Shouldn't we look at cross-build-files in meta.yaml in that case?
As you can see in the buildpkg.py change, only cross-build-files are installed under the hostsitepackages on in-tree build (I think there are some room to optimize this logic though).
Also, site-packages-extras maybe should have been called site-packages-cross-files or something a bit more descriptive...
Totally agree, but the folder site-packages-extras is generated when creating the xbuildenv, so we'll need to fix there too.
| @@ -205,33 +205,6 @@ def test_install_force( | |||
| assert (tmp_path / version / ".installed").exists() | |||
| assert manager.current_version == version | |||
|
|
|||
| def test_install_cross_build_packages( | |||
There was a problem hiding this comment.
It feels like we could use an updated version of this test?
There was a problem hiding this comment.
Thanks @ryanking13! I made some comments but it generally looks good.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This changes how we handle unisolated packages + hostsitepackages directory.
The current mechanism of unisolated packages is as follows:
However, this mechanism introduced a few issues, such as pyodide/pyodide#5012 (comment).
This PR changes it in the following way: