-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #271: Use parametrize markers params for getting example_kwargs #272
Open
sliwinski-milosz
wants to merge
12
commits into
pytest-dev:master
Choose a base branch
from
sliwinski-milosz:gherkin_reporter_parametrized_tests_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+191
−47
Open
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8cbcab6
Fixes #271: Use parametrize markers params for getting example_kwargs
sliwinski-milosz e016791
_get_param_names function renamed to _coerce_list
sliwinski-milosz ca0efed
Coerce getting params names as list on get_parametrize_params
sliwinski-milosz b3c0e3f
Merge branch 'master' into gherkin_reporter_parametrized_tests_fix
sliwinski-milosz 646fc1c
Test parametrized tests in gherkin expanded mode
sliwinski-milosz 432e0e0
Linter fixes
sliwinski-milosz 645a9f2
Merge branch 'master' into gherkin_reporter_parametrized_tests_fix
sliwinski-milosz df1f21e
Merge branch 'master' into gherkin_reporter_parametrized_tests_fix
youtux 8fef144
When and Then steps added to test_parametrized_single_param test
sliwinski-milosz cd4d74a
test_parametrized_single_param test renamed to test_parametrized_sing…
sliwinski-milosz 256f6c6
Rewrite tests of gherkin terminal reporter expanded mode to pytest-bd…
sliwinski-milosz 0646548
Merge branch 'master' into gherkin_reporter_parametrized_tests_fix
sliwinski-milosz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this test asserting? There is no "then" step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You already have asked that question :). Shall we add comment somewhere in the code explaining what this test is testing?
#272 (comment)