feat: create quote response submit method, typescript #312
+215
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danimhr
reviewed
Jan 8, 2025
| user_wallet_address: quoteRequest.userWallet.toBase58(), | ||
| version: "v1" as const, | ||
| }; | ||
| const response = await client.POST("/v1/opportunities/quote", { |
There was a problem hiding this comment.
the error should be caught below, i don't think we wrap anything else in try in the JS SDK?
There was a problem hiding this comment.
The await should be wrapped in try, or it cause the whole process to be killed (if any throw happens in the POST function we used)
danimhr
approved these changes
Jan 8, 2025
anihamde
added a commit
that referenced
this pull request
Jan 9, 2025
* create quote response submit method, typescript * ignore generated files in linting * bump package version * convert to date * add todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method to submit a quote request from the client. It only adds this to the TS sdk, and it is not complete--it is meant just to serve as a quick reference for integrating routers.