feat!: add market schedule #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
approved these changes
Dec 20, 2024
ali-bahjati
force-pushed
the
feat/add-market-schedule
branch
from
973f19d to
608a6ff
Compare
This change removes the hard-coded calendar and adds MarketSchedule class to offer the same features using `schedule` metadata in the products. feat!: add market schedule This change removes the hard-coded calendar and adds MarketSchedule class to offer the same features using `schedule` metadata in the products.
ali-bahjati
force-pushed
the
feat/add-market-schedule
branch
from
608a6ff to
50d26aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the hard-coded calendar and adds MarketSchedule class to offer the same features using
schedulemetadata in the products.It is a breaking change and requires all downstream users to stop relying on hard-coded dates. They'll need to read the schedule from the product accounts and it will remove the need to keep updating this package.
The new logic is tested extensively to ensure the output is correct and I've manually made sure it matches the removed logic.