-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert _default_params
to dataclass
#237
Conversation
24baf76
to
edd1b0f
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Ok, I let GitHub merge the |
@shaypal5 done and resolved last linting issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I love the new data class, and the deprecation warning. Let's remember to bump the major part of the version number when we push out the breaking change of delete the set_deafult_params
method and any of its friends.
improve readability and reduce eventual typo errors while manipulating keys
with IDE it is now feasible to track usage
also suggesting to rename
default_params
toglobal_params
as it is better fit