Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Significant slowdown on nested tables depending on syntax #324

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

frostming
Copy link
Contributor

@frostming frostming commented Nov 7, 2023

Fixes #193
Fixes #301
Fixes #319

Signed-off-by: Frost Ming [email protected]

@frostming
Copy link
Contributor Author

With this change, I observed a 4x faster parsing the file given in #319 . Further improvement may need a rewrite on a large scale.

@davemc0 is this acceptable from your side?

@davemc0
Copy link

davemc0 commented Nov 9, 2023

Thank you! This is very much appreciated. I'm not sure it will bring all use cases into the acceptable range since some were six minutes, but it will definitely enable several of our use cases.

Thanks again.

@frostming frostming merged commit 238fec1 into master Nov 15, 2023
22 checks passed
@frostming frostming deleted the frostming/issue193 branch November 15, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants