Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Trio mode #49

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Implement Trio mode #49

merged 1 commit into from
Jul 25, 2018

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Jul 23, 2018

Fixes gh-9
Documentation in gh-47

@codecov
Copy link

codecov bot commented Jul 24, 2018

Codecov Report

Merging #49 into master will increase coverage by 1.39%.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   95.35%   96.75%   +1.39%     
==========================================
  Files          11       13       +2     
  Lines         280      308      +28     
  Branches       26       30       +4     
==========================================
+ Hits          267      298      +31     
+ Misses          9        6       -3     
  Partials        4        4
Impacted Files Coverage Δ
pytest_trio/_tests/test_hypothesis_interaction.py 100% <100%> (ø) ⬆️
pytest_trio/_tests/test_trio_mode.py 100% <100%> (ø)
pytest_trio/enable_trio_mode.py 100% <100%> (ø)
pytest_trio/plugin.py 93.54% <91.66%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a972dc6...910d79c. Read the comment docs.

Copy link
Member

@touilleMan touilleMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty good to me ;-)

@njsmith
Copy link
Member Author

njsmith commented Jul 24, 2018

Do you want to click merge, or is there something you think we should wait for...?

(I did realize I didn't do release notes for this, but this next release is going to have a chunk of stuff so maybe it's better to write it all together?)

@touilleMan
Copy link
Member

touilleMan commented Jul 24, 2018 via email

@njsmith njsmith merged commit c905f15 into python-trio:master Jul 25, 2018
@njsmith njsmith deleted the trio-mode branch July 25, 2018 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants