-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the concept of a tree variable (TreeVar) #1543
Open
oremanj
wants to merge
9
commits into
python-trio:main
Choose a base branch
from
oremanj:scopevar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt nursery rather than from the spawner
Codecov Report
@@ Coverage Diff @@
## master #1543 +/- ##
========================================
Coverage 99.70% 99.71%
========================================
Files 111 111
Lines 14035 14175 +140
Branches 1084 1090 +6
========================================
+ Hits 13994 14134 +140
Misses 27 27
Partials 14 14
|
oremanj
changed the title
Add the concept of a scope variable (ScopeVar)
Add the concept of a tree variable (TreeVar)
Jun 1, 2020
This was referenced Jul 25, 2021
oremanj
added a commit
to oremanj/tricycle
that referenced
this pull request
Jun 5, 2023
A TreeVar acts like a context variable that is inherited at nursery creation time (and then by child tasks of that nursery) rather than at task creation time. They are useful for providing 'ambient' access to a resource that is tied to an `async with` block in the parent task, such as an open file or trio-asyncio event loop. Prior art: python-trio/trio#1543 (never made it into mainline Trio). The implementation without Trio core support is somewhat less efficient, but still workable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TreeVars are like ContextVars except that their initial value in new tasks is determined differently: they are inherited from the new task's parent nursery rather than from its spawner. #1523 has some discussion of the possible uses.
Fixes #1523