Geojson: allow null geometry objects #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://datatracker.ietf.org/doc/html/rfc7946#section-3.2 A Feature object has a member with the name "geometry". The value of the geometry member SHALL be either a Geometry object as defined above or . . . a JSON null value.
Conengmo
changed the title
|
Thanks @hansthen! Nice enhancement, good PR. I wanted to merge it now already, but I was also thinking it would be nice to have a test case for this null case in |
|
I do not have a lot of time this week, but I will put it on my bucket list. If I remember correctly I also promised to add more tests to the |
hansthen
added a commit
to hansthen/folium
that referenced
this pull request
Jan 24, 2024
* GeoJson objects can have null geometry objects See https://datatracker.ietf.org/doc/html/rfc7946#section-3.2 A Feature object has a member with the name "geometry". The value of the geometry member SHALL be either a Geometry object as defined above or . . . a JSON null value. * Missed an instance geometry cannot be null * Handle empty geojson features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GeoJson objects can have
nullgeometrymembers according to the standard. However, if we pass anullvalue to folium, this will cause an error inm.get_bounds().See https://datatracker.ietf.org/doc/html/rfc7946#section-3.2
A Feature object has a member with the name "geometry". The value of the geometry member SHALL be either a Geometry object as defined above or . . . a JSON null value.