Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix third party scheduled tests running on forks #525

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Fix third party scheduled tests running on forks #525

merged 2 commits into from
Dec 22, 2024

Conversation

brianschubert
Copy link
Contributor

Background in #226, #522

Moves a comment to outside of the if: condition so that the condition doesn't always evaluate to true (see #522 (comment)).

Also did some opportunistic refactoring:

  • Simplified the condition: A || (B && ~A) is equivalent to A || B
  • Refactored the repeated condition into a single predicate job. This way we don't have to repeat the same logic in each test job. I made this change in a separate commit which I can roll back if keeping the original setup is preferred.

@JelleZijlstra JelleZijlstra merged commit 15d48b2 into python:main Dec 22, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianschubert @JelleZijlstra