Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy identities via FillArrays #94

Merged
merged 18 commits into from
May 4, 2023
Merged

Lazy identities via FillArrays #94

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f167647
Have identityoperator return an Eye
Apr 19, 2023
c040c21
Handle Eyes in LazyTensor mul!()
Apr 19, 2023
12024ae
Fix identityoperator semantics. Add a test.
Apr 20, 2023
6a7f77f
Simpify _tpops_tuple
Apr 21, 2023
d351b6b
Add compat entry for FillArrays
Apr 21, 2023
3d7c392
Filter out all square eyes. Simplify code.
Apr 21, 2023
dfdece9
Try to make Aqua happier
Apr 21, 2023
9a4374c
Explicit eye tests
Apr 22, 2023
e315bc9
Only turn off ambiguity checking for reshape
Apr 22, 2023
35dba7e
Merge branch 'master' into lazyeye
amilsted Apr 22, 2023
9cb381b
Test left action.
Apr 23, 2023
0c3930b
Restore more efficient handling of isometries
Apr 23, 2023
5db85b6
Remember why we need to distinguish beta==0
Apr 23, 2023
ca3f765
More specific Aqua exclusion
Apr 23, 2023
7fcb38f
Fix test dependencies.
Apr 23, 2023
9045bc2
Handle alpha=0 and beta=0 better.
Apr 24, 2023
d9fa97c
Merge branch 'master' into lazyeye
amilsted Apr 24, 2023
c569b86
Managed to munge tests in merge.
Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/operators_lazytensor.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,8 +331,13 @@ function _tp_matmul_mid!(result, a::AbstractMatrix, loc::Integer, b, α::Number,
size(b, loc) == size(a, 2) && size(result, loc) == size(a, 1) || throw(DimensionMismatch("Dimensions of Eye matrix do not match subspace dimensions."))
d = min(size(a)...)

rmul!(result, β)
@strided result_r[:, 1:d, :] .+= α .* br[:, 1:d, :]
if !iszero(β)
amilsted marked this conversation as resolved.
Show resolved Hide resolved
rmul!(result, β)
@strided result_r[:, 1:d, :] .+= α .* br[:, 1:d, :]
else
fill!(result, zero(eltype(result)))
@strided result_r[:, 1:d, :] .= α .* br[:, 1:d, :]
end

return result
end
Expand Down