-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add legacy config root #213
Conversation
f371fc0
to
8ff9c31
Compare
db20622
to
ab3dc15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fjtirado, should we switch to ConfigMapping as described here https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.14#for-extension-developers? Are there any problems on your side or was is just the quick&easy solution to enable the legacy-property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some reading, i understand, that 'per default' all config-properties have to start with 'quarkus' - that might be breaking change.
There is a workaround https://github.com/orgs/quarkiverse/discussions/228#discussioncomment-10455441 implementing a smallrye config customizer...
But afaik our configs are all prefixed with 'quarkus' - so no problem for us
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChMThiel To be honest, I took the simplest approach, which was to specify the legacy property. Let me know if you try to change to ConfigMapping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.