Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legacy config root #213

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Add legacy config root #213

merged 4 commits into from
Aug 20, 2024

Conversation

fjtirado
Copy link
Contributor

No description provided.

@fjtirado fjtirado merged commit 30b58bd into quarkiverse:main Aug 20, 2024
1 check passed
@fjtirado fjtirado changed the title Replace config root by config mapping Add legacy config root Aug 20, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjtirado, should we switch to ConfigMapping as described here https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.14#for-extension-developers? Are there any problems on your side or was is just the quick&easy solution to enable the legacy-property?

Copy link
Contributor

@ChMThiel ChMThiel Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some reading, i understand, that 'per default' all config-properties have to start with 'quarkus' - that might be breaking change.
There is a workaround https://github.com/orgs/quarkiverse/discussions/228#discussioncomment-10455441 implementing a smallrye config customizer...
But afaik our configs are all prefixed with 'quarkus' - so no problem for us

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChMThiel To be honest, I took the simplest approach, which was to specify the legacy property. Let me know if you try to change to ConfigMapping

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChMThiel To be honest, I took the simplest approach, which was to specify the legacy property. Let me know if you try to change to ConfigMapping

I already did: see a7bdd4d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants