Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more defensive in setting metadata for observability events #1170

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

geoand
Copy link
Collaborator

@geoand geoand commented Dec 18, 2024

No description provided.

Without this change it was possible in some of the ITs,
depending on the mock response from the server, to have NPEs being thrown.
These NPEs didn't affect the response, but they did
clutter up the logs
@geoand geoand requested a review from a team as a code owner December 18, 2024 07:59
@geoand geoand merged commit e097a17 into main Dec 18, 2024
64 checks passed
@geoand geoand deleted the observability-npes branch December 18, 2024 08:16
Copy link

quarkus-bot bot commented Dec 18, 2024

Status for workflow Build (on pull request)

This is the status report for running Build (on pull request) on commit 10d8159.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant