Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes to the build #1187

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Some fixes to the build #1187

merged 1 commit into from
Jan 3, 2025

Conversation

jmartisk
Copy link
Collaborator

@jmartisk jmartisk commented Jan 3, 2025

No description provided.

@jmartisk jmartisk requested a review from a team as a code owner January 3, 2025 07:59
<optional>true</optional>
</dependency>
<dependency>
<groupId>io.quarkiverse.langchain4j</groupId>
<artifactId>quarkus-langchain4j-testing-scorer-core</artifactId>
<version>999-SNAPSHOT</version>
<version>${project.version}</version>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this would be a problem when releasing and changing the project.version to something else than 999-SNAPSHOT

@@ -17,12 +17,13 @@
<dependency>
<groupId>dev.langchain4j</groupId>
<artifactId>langchain4j-embeddings-bge-small-en-v15</artifactId>
<version>${langchain4j-embeddings.version}</version>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a problem when I bump langchain4j.version to a version different than langchain4j-embeddings.version (for development purposes) - because then the version of this artifact is taken from the langchain4j bom instead of the langchain4j-embeddings.version property, making it inconsistent and forcing me to compile the embeddings repo as well to be able to build

@jmartisk jmartisk merged commit 1c34c40 into quarkiverse:main Jan 3, 2025
69 of 70 checks passed
@jmartisk jmartisk deleted the build-fixes branch January 3, 2025 08:17
Copy link

quarkus-bot bot commented Jan 3, 2025

Status for workflow Build (on pull request)

This is the status report for running Build (on pull request) on commit 8f5da0c.

Failing Jobs

Status Name Step Failures Logs Raw logs
✔️ JVM tests - integration-tests - Java 17 Logs Raw logs
JVM tests - integration-tests - Java 21 Run tests of integration-tests with JDK 21 Failures Logs Raw logs
✔️ JVM tests - integration-tests - Java 23 Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM tests - integration-tests - Java 21 #

📦 integration-tests/rag-pgvector-flyway

org.acme.example.openai.RAGWithMetadataFilterTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:634)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptBeforeAllMethod(QuarkusTestExtension.java:702)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
	at io.quarkus.runtime.Application.start(Application.java:101)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants