Replace the SQL chatbot Data Ingestion with Camel Route & fix the GPT… #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
geoand
reviewed
Jan 3, 2025
samples/sql-chatbot/src/main/java/io/quarkiverse/langchain4j/sample/chatbot/CsvIngestor.java
Outdated
Show resolved
Hide resolved
maxandersen
reviewed
Jan 4, 2025
| public class Movie { | ||
|
|
||
| @Id | ||
| @GeneratedValue | ||
| private int id; | ||
|
|
||
| @Column(name = "index") | ||
| @DataField(pos = 1) |
There was a problem hiding this comment.
Does camel not support csv column names ? Seems redundant having to specify order here ?
There was a problem hiding this comment.
According to the doc : Camel Bindy doesn't. And it's not related to persistence so I don't know exactly if we can improve that
… default model name in the doc
zbendhiba
force-pushed
the
improve-sql-chatbot-data-ingestion
branch
from
c020ad0 to
ec779a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… default model name in the doc