Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of invalid json reprompt #1204

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

edeandrea
Copy link
Collaborator

Allow customization of invalid json reprompt.

In some implementations I'm finding that the message Make sure you return a valid JSON object following the specified format is too generic. On specific implementations I'd like to include the json format in the reprompt message.

This change allows implementors to override the message, or change the implementation of the reprompt altogether (maybe an implementor just wants to fail?).

This change is 100% backwards compatible with current behavior but allows implementors to customize.

@edeandrea edeandrea requested a review from a team as a code owner January 8, 2025 13:01
@edeandrea edeandrea force-pushed the enhance-json-guardrail branch from c707f15 to b03f26d Compare January 8, 2025 13:02
Copy link

quarkus-bot bot commented Jan 8, 2025

Status for workflow Build (on pull request)

This is the status report for running Build (on pull request) on commit b03f26d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand requested a review from cescoffier January 8, 2025 13:55
@geoand geoand merged commit 7d10993 into quarkiverse:main Jan 9, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants