Add missing result in EvaluationResult #1209
Conversation
| assertThat(content).contains("- **tag1**: 100.0"); | ||
| assertThat(content).contains("- **tag2**: 0.0"); | ||
| assertThat(content).contains("## Details"); | ||
| assertThat(content).contains("### Sample1: PASSED"); |
There was a problem hiding this comment.
@cescoffier my take on reporting results
as it's supposed to be markdown this should be the way to go?
differs from - Sample1: PASSED, we could consider to harmonize it
for now it is backwards compatible
There was a problem hiding this comment.
Yes, it can be improved.
Reporting had not been my priority when I did that work.
This comment has been minimized.
This comment has been minimized.
| var actualEvaluations = report.evaluations().stream() | ||
| .map(e -> "%s[%s;%s=%s]".formatted(e.sample().name(), e.sample().expectedOutput(), e.result(), e.passed())) | ||
| .toList(); | ||
| assertThat(actualEvaluations).containsExactlyInAnyOrder( |
There was a problem hiding this comment.
@cescoffier order is random for now (was a bit of luck for the old version to be successful)
should n't we order it? (separate change)
There was a problem hiding this comment.
Yes, it would be good to have a stable order.
flyinfish
force-pushed
the
discussions/1206
branch
from
6abc220 to
db9e0e5
Compare
This comment has been minimized.
This comment has been minimized.
pleasure |
|
|
Add option to write result and expectedOutput to file when writing Evaluation Report Closes quarkiverse#1208
geoand
force-pushed
the
discussions/1206
branch
from
db9e0e5 to
f74c1b4
Compare
|
I rebased and force pushed to main |
Status for workflow
|
Add option to write result and expectedOutput to file when writing Evaluation Report
Closes #1208