Laufende Nummer in den Form Elementen #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderschmitz
force-pushed
the
feat/repetition-number
branch
from
c0b3984 to
d5bb595
Compare
- ref: questionpy-org/moodle-qtype_questionpy#38 - removes as much logic from the jinja forms as possible - allows {qpy:repno} to be replaced with the current repetition number
alexanderschmitz
force-pushed
the
feat/repetition-number
branch
from
d5bb595 to
0007bf5
Compare
- missing context in creation of CxdGroupElement - missing contextualization for CxdSelectElement - added identifier in the example
|
Wäre es nicht einfacher (und wesentlich kürzer), das in den Jinja-Templates zu lösen? Also aus |
|
Aktuell wäre es einfacher das in den Templates zu lösen, aber ich denke für die Zukunft ist es leichter, wenn weniger Logik in den Templates liegt. Ich hab das jetzt schon öfter gemerkt, dass ein Refactoring der Templates fehleranfällig ist. Ich denke, dass das einführen von neuen Kontextvariablen so leichter ist. |
MHajoha
approved these changes
Jan 9, 2024
|
Fast vergessen: Im Moodle-Plugin fangen die Nummern bei 1 an. Das halte ich hier auch für sinnvoller |
- includes other requested changes from the PR
MHajoha
reviewed
Jan 9, 2024
MHajoha
approved these changes
Jan 11, 2024
janbritz
approved these changes
Jan 11, 2024
MartinGauk
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Siehe PR 43
Außerdem:
refactoring: Logik wird aus den Jinja2 templates verschoben (besseres Debugging, Fehlervermeidung, Typing, ...)
Möglichkeit in Zukunft die
contextualizeMethoden zu erweitern.ref: Plugin Issue 38