Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cleanup-closed-pull-requests action #1136

Merged
merged 12 commits into from
Oct 4, 2023
Merged

Add cleanup-closed-pull-requests action #1136

merged 12 commits into from
Oct 4, 2023

Conversation

int128
Copy link
Member

@int128 int128 commented Sep 29, 2023 •
edited
Loading

Problem to solve

  • Argo CD is eventually stuck on deletion, if an application is deleted during PreSync hook.
  • The cleanup workflow becomes complex. It needs much effort for adding a new feature.

How to solve

I'd like to add cleanup-closed-pull-requests action.
See README.md for details.

Related: #1126

@int128 int128 changed the title Add delete-pull-request-namespaces Add delete-closed-pull-requests action Oct 3, 2023
@int128 int128 changed the title Add delete-closed-pull-requests action Add cleanup-closed-pull-requests action Oct 3, 2023
github-actions bot added a commit that referenced this pull request Oct 3, 2023
@github-actions
git-delete-namespace-application: delete 1 applications
6b31a4f 
#1136
71cc5b0
@int128 int128 marked this pull request as ready for review October 3, 2023 06:03
@int128 int128 requested review from semnil, panicboat, aoi1, 44smkn and a team October 4, 2023 02:20
semnil
semnil approved these changes Oct 4, 2023
View reviewed changes
cleanup-closed-pull-requests/README.md Outdated Show resolved Hide resolved
@int128 @semnil
Fix typo
92ccc91 
Co-authored-by: Tetsuya Shinone <[email protected]>
github-actions bot added a commit that referenced this pull request Oct 4, 2023
@github-actions
git-delete-namespace-application: delete 1 applications
84149ba 
#1136
2ecfe02
@int128 int128 merged commit 4a57eed into main Oct 4, 2023
@int128 int128 deleted the int128/delete-closed-pull-requests branch October 4, 2023 07:58
@int128 int128 mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoi1 aoi1 aoi1 approved these changes

@panicboat panicboat panicboat approved these changes

@semnil semnil semnil approved these changes

@44smkn 44smkn Awaiting requested review from 44smkn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@int128 @semnil @panicboat @aoi1