Specifically handle offline case in pr_init()
#2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realised that we're checking whether or not the host is online further down, so we might as well use that a little earlier to give a more informative message.
hadley
commented
Sep 20, 2024
| @@ -213,10 +224,6 @@ pr_init <- function(branch) { | |||
| ui_bullets(c("v" = "Pulling changes from {.val {remref}}.")) | |||
| git_pull(remref = remref, verbose = FALSE) | |||
| } | |||
| } else { | |||
| ui_bullets(c( | |||
There was a problem hiding this comment.
Already warned that we can't do this above
There was a problem hiding this comment.
We didn't actually warn about this, i.e. that we can't make sure the base branch is current. So we could add something around line 175. Or not.
There was a problem hiding this comment.
Ok, tweaked that message a little bit.
jennybc
approved these changes
Oct 1, 2024
| @@ -213,10 +224,6 @@ pr_init <- function(branch) { | |||
| ui_bullets(c("v" = "Pulling changes from {.val {remref}}.")) | |||
| git_pull(remref = remref, verbose = FALSE) | |||
| } | |||
| } else { | |||
| ui_bullets(c( | |||
There was a problem hiding this comment.
We didn't actually warn about this, i.e. that we can't make sure the base branch is current. So we could add something around line 175. Or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised that we're checking whether or not the host is online further down, so we might as well use that a little earlier to give a more informative message.