[passport-gated]: update required parameters

raid-guild · Oct 10, 2023 · 1585762 · 1585762
1 parent a6e305f
commit 1585762
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 5 deletions.
diff --git a/src/validations/passport-gated/examples.json b/src/validations/passport-gated/examples.json
@@ -1,11 +1,23 @@
 [
+  {
+    "name": "Example of a passport gated validation",
+    "author": "0x000000000000000000000000000000000000dead",
+    "space": "fabien.eth",
+    "network": "1",
+    "snapshot": "latest",
+    "params": {
+      "scoreThreshold": 0
+    },
+    "valid": true
+  },
   {
     "name": "Example of a passport gated validation",
     "author": "0x24F15402C6Bb870554489b2fd2049A85d75B982f",
     "space": "fabien.eth",
     "network": "1",
     "snapshot": "latest",
     "params": {
+      "scoreThreshold": 20,
       "stamps": ["Ens", "Github", "Snapshot"],
       "operator": "OR"
     },
@@ -18,9 +30,9 @@
     "network": "1",
     "snapshot": "latest",
     "params": {
+      "scoreThreshold": 20,
       "stamps": ["Ens", "Github", "Snapshot"],
-      "operator": "OR",
-      "scoreThreshold": 20
+      "operator": "OR"
     },
     "valid": false
   }

diff --git a/src/validations/passport-gated/index.ts b/src/validations/passport-gated/index.ts
@@ -167,8 +167,10 @@ export default class extends Validation {
   async validate(currentAddress = this.author): Promise<boolean> {
     const requiredStamps = this.params.stamps || [];
     const operator = this.params.operator;
-    const scoreThreshold = this.params.scoreThreshold || 0;
-    if (!operator) throw new Error('Operator is required');
+    const scoreThreshold = this.params.scoreThreshold;
+
+    if (scoreThreshold === undefined) throw new Error('Score threshold is required');
+    if (requiredStamps.length > 0 && !operator) throw new Error('Operator is required');
 
     const provider = snapshot.utils.getProvider(this.network);
     const proposalTs = (await provider.getBlock(this.snapshot)).timestamp;

diff --git a/src/validations/passport-gated/schema.json b/src/validations/passport-gated/schema.json
@@ -150,7 +150,7 @@
           "default": 0
         }
       },
-      "required": ["stamps", "operator"],
+      "required": ["scoreThreshold"],
       "additionalProperties": false
     }
   }