Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trigger technologies and fix technology tree #445

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

ukarlsson
Copy link
Contributor

@ukarlsson ukarlsson commented Dec 4, 2024

Many thanks for looking at the previous PRs!

This PR aims to align the K2 technology tree for 2.0 with what it was in 1.1, in particular removing the trigger technologies and attempting to reconstruct what we had in 1.1. It seems like this is the easiest way to fix the K2 technology tree so it makes sense again. But I can adjust if you think otherwise! This was a bit more tricky than the previous PRs.

I have been running 1.1 and 2.0 side-by-side and comparing the following:

  • starting inventory (100 % checked)
  • starting available techs (100 % checked)
  • tech tree (partially verified - but critical things affected by trigger technologies 100 % checked)
  • recipes (partially verified - but critical things affected by trigger technologies 100 % checked)

Also partially play-tested.

Needed to enable a number of items that were disabled by default in 2.0:

  • copper cable
  • pistol
  • lab

A few technologies had to be recreated based on factorio-data from 1.1

For steel-axe:

{
  type = "technology",
  name = "steel-axe",
  icon_size = 256,
  icon = "__base__/graphics/technology/steel-axe.png",
  effects =
  {
    {
      type = "character-mining-speed",
      modifier = 1
    }
  },
  prerequisites = {"steel-processing"},
  unit =
  {
    count = 50,
    ingredients =
    {
      {"automation-science-pack", 1}
    },
    time = 30
  },
  order = "c-c-a"
},

For electronics

{
  type = "technology",
  name = "electronics",
  icon_size = 256, icon_mipmaps = 4,
  icon = "__base__/graphics/technology/electronics.png",
  prerequisites = {"automation"},
  unit =
  {
    count = 30,
    ingredients = {{"automation-science-pack", 1}},
    time = 15
  },
  order = "a-d-a"
},

For oil-processing

{
  type = "technology",
  name = "oil-processing",
  icon_size = 256, icon_mipmaps = 4,
  icon = "__base__/graphics/technology/oil-gathering.png",
  prerequisites = {"fluid-handling"},
  effects =
  {
    {
      type = "unlock-recipe",
      recipe = "pumpjack"
    },
    {
      type = "unlock-recipe",
      recipe = "oil-refinery"
    },
    {
      type = "unlock-recipe",
      recipe = "chemical-plant"
    },
    {
      type = "unlock-recipe",
      recipe = "basic-oil-processing"
    },
    {
      type = "unlock-recipe",
      recipe = "solid-fuel-from-petroleum-gas"
    }
  },
  unit =
  {
    count = 100,
    ingredients = {{"automation-science-pack", 1}, {"logistic-science-pack", 1}},
    time = 30
  },
  order = "d-a"

}

For how it looks in the UX (this is running with the icon fix from the other PR):

Screenshot From 2024-12-04 17-35-06

Screenshot From 2024-12-04 17-27-28
Screenshot From 2024-12-04 17-27-37

@ukarlsson ukarlsson force-pushed the uk/trigger-technologie-remove branch from 5d7ef8f to 62c0e30 Compare December 4, 2024 16:17
@ukarlsson ukarlsson changed the title Remove trigger technologies Remove trigger technologies and fix technology tree Dec 4, 2024
@@ -26,6 +26,11 @@ data_util.add_or_replace_ingredient(
"iron-plate",
{ type = "item", name = "iron-beam", amount = 4 }
)
data_util.add_or_replace_ingredient(
"assembling-machine-1",
"electronic-circuit",
Copy link
Contributor Author

@ukarlsson ukarlsson Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw now that there is some code in prototypes/updates/add-automation-core-recipes.lua but it seems like it does not trigger and that is why it broke for multiple recipes, I suppose I could try to figure out what is wrong. It seems to be the same issue for

  • assembling-machine-1
  • electric-mining-drill
  • splitter

@raiguard
Copy link
Owner

raiguard commented Dec 4, 2024

I was actually planning on keeping the trigger technologies, but I haven't looked into how it will behave with the basic tech card yet.

@ukarlsson
Copy link
Contributor Author

ukarlsson commented Dec 5, 2024

Ok right. From having looked at it a bit closer I think it is easier for the 2.0 work to first get it working as it was before and then add K2 specific trigger technologies into K2 tree in a separate PR.

K2 kind of chokes on the vanilla triggers so that would be a much bigger task with product decisions than just restoring functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants