Add support for yarnpkg #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debian and derivates have yarn packaged as yarnpkg
|
Maybe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian and derivates have yarn packaged as yarnpkg. When cssbundling-rails run in such a system, it could not detect apt installed yarn currently, as the executable is named
yarnpkg(since there was another yarn executable already). This PR adds the capability for cssbunding-rails to work with yarnpkg as well as yarn. ruby-cssbundling-rails package in debian is already shipped with this patch, and is it what the gitlab package utilizes to work with yarnpkg. Merging this would help with having to carry this patch downstream.One caveat here is that since yarn and yarnpkg are not different except in names, they both use the same yarn.lock. This means there can't be a convenient "yarn.lock" => "yarn" detection available, but I believe it is worth the tradeoff. I am no ruby wizard, so it is possible that I have missed out on other details and/or checks, so review and inputs are much welcome.