-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: generate and maintain in-repo module documentation #75
base: main
Are you sure you want to change the base?
Conversation
I reviewed the changes and do not see anything blocking our operation with the repo... @dnoland1 I think we can approve and merge the PR. |
@devenkulkarni I fixed the merge conflict in README.md. Who can merge this? |
20f240f
to
b339394
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the error in the CI phase, it may be necessary to add the environment variables as done for the other pipeline.
env:
METAL_AUTH_TOKEN: ${{ secrets.metal_auth_token }}
TF_VAR_project_name: Harvester Labs
TF_VAR_api_key: ${{ secrets.metal_auth_token }}
cc: @displague
The generate-terraform-docs workflow will use the terraform-docs/gh-actions action to generate Terraform documentation based on the module's provider requirements, variables, and outputs. The peter-evans/create-pull-request action will open new pull requests to ensure that the README.md of each module, including the root module, includes this generated content and that the content stays up to date as changes are made to the project. Signed-off-by: Marques Johansson <[email protected]>
If https://github.com/rancherlabs/terraform-harvester-equinix/blob/main/variables.tf#L21 was true (make the Harvester Demo project by default), the only required variables would be Metal API tokens. |
Good point! Please, open an issue to set the default value to true. |
The generate-terraform-docs workflow will use the terraform-docs/gh-actions action to generate Terraform documentation based on the module's provider requirements, variables, and outputs.
The peter-evans/create-pull-request action will open new pull requests to ensure that the README.md of each module, including the root module, includes this generated content and that the content stays up to date as changes are made to the project.
An example of the output is here: https://github.com/equinix-labs/terraform-equinix-metal-k3s?tab=readme-ov-file#terraform-module-documentation