Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use bar chart from rango client #29

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

mikasackermn
Copy link
Collaborator

Using Rango-client's barChart

Copy link
Collaborator

@RyukTheCoder RyukTheCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx I just added some comments. Most of them should be applied on the PR related to charts package.

components/statistics/ChartBarBox/index.tsx Outdated Show resolved Hide resolved
components/statistics/ChartBarBox/index.tsx Outdated Show resolved Hide resolved
components/statistics/ChartBarBox/index.tsx Outdated Show resolved Hide resolved
components/statistics/ChartBarBox/index.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@RyukTheCoder RyukTheCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nikaaru nikaaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks,
LGTM

@mikasackermn mikasackermn force-pushed the feat/rf-1739-use-chart-package branch from ad10a6b to 0f367c9 Compare September 16, 2024 13:50
@nikaaru nikaaru merged commit d0b1260 into next Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants