IMX500: Add support for rotation and image flip #6584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds rotation support for the IMX500. Supported angles: - 0: 0 degrees - 1: 90 degrees - 2: 180 degrees - 3: 270 degrees Signed-off-by: Katsu Nakamura <[email protected]>
Adds image flip support for IMX500. Supported modes: 0: No flip 1: Flip horizontal 2: Flip vertical 3: Flip horizontal and vertical Signed-off-by: Katsu Nakamura <[email protected]>
6by9
reviewed
Jan 7, 2025
| @@ -235,6 +238,7 @@ enum pad_types { IMAGE_PAD, METADATA_PAD, NUM_PADS }; | |||
|
|
|||
| #define V4L2_CID_USER_IMX500_INFERENCE_WINDOW (V4L2_CID_USER_IMX500_BASE + 0) | |||
| #define V4L2_CID_USER_IMX500_NETWORK_FW_FD (V4L2_CID_USER_IMX500_BASE + 1) | |||
| #define V4L2_CID_USER_IMX500_ROTATION (V4L2_CID_USER_IMX500_BASE + 2) | |||
There was a problem hiding this comment.
Why does this need to be a custom control rather than V4L2_CID_ROTATE? (Documented in https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/control.html)
How does this affect the resolution of the output image? Normally you'd rotate the 4056x3040 image to give a 3040x4056 output, so the output format needs to change.
| .id = V4L2_CID_USER_IMX500_ROTATION, | ||
| .ops = &imx500_ctrl_ops, | ||
| .type = V4L2_CTRL_TYPE_INTEGER, | ||
| .flags = V4L2_CTRL_FLAG_EXECUTE_ON_WRITE, |
There was a problem hiding this comment.
Do you really need to rewrite the register even if setting it to the same value?
| @@ -217,6 +217,9 @@ | |||
| /* Rotate angle */ | |||
| #define IMX500_REG_ADDR_ROTATION CCI_REG8(0xD680) | |||
|
|
|||
| /* Flip vertical/horizontal */ | |||
| #define IMX500_REG_ADDR_IMG_ORIENTATION CCI_REG8(0x0101) | |||
There was a problem hiding this comment.
Already defined and used as IMX500_REG_ORIENTATION
| @@ -239,6 +242,7 @@ enum pad_types { IMAGE_PAD, METADATA_PAD, NUM_PADS }; | |||
| #define V4L2_CID_USER_IMX500_INFERENCE_WINDOW (V4L2_CID_USER_IMX500_BASE + 0) | |||
| #define V4L2_CID_USER_IMX500_NETWORK_FW_FD (V4L2_CID_USER_IMX500_BASE + 1) | |||
| #define V4L2_CID_USER_IMX500_ROTATION (V4L2_CID_USER_IMX500_BASE + 2) | |||
| #define V4L2_CID_USER_IMX500_IMG_FLIP (V4L2_CID_USER_IMX500_BASE + 3) | |||
There was a problem hiding this comment.
Again why a custom control? V4L2_CID_HFLIP and V4L2_CIF_VFLIP exist and are already implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for rotation and image flip functionality for the IMX500.
Rotation Support
Image Flip Support